fix(iOS, Tabs): update tab bar item only when necessary #3290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmichalikk
approved these changes
Oct 9, 2025
t0maboro
approved these changes
Oct 9, 2025
kkafar
requested changes
Oct 13, 2025
| #if !RCT_NEW_ARCH_ENABLED | ||
| BOOL _tabItemNeedsAppearanceUpdate; | ||
| BOOL _tabScreenOrientationNeedsUpdate; | ||
| BOOL _tabBarItemNeedsBaseChange; |
There was a problem hiding this comment.
When reading the code for the first time the base part made no sense to me. What we want to signal here is that the tab bar item needs to be recreated & requires allocating completely new instance. What about naming it _tabBarItemNeedsRecreation then? What do you think?
There was a problem hiding this comment.
Also rename the changeTabBarItem appropriately. createTabBarItem?
Comment on lines
+58
to
+71
| } else if (screenView.systemItem != RNSBottomTabsScreenSystemItemNone) { | ||
| // Restore default system item icon | ||
| UITabBarSystemItem systemItem = | ||
| rnscreens::conversion::RNSBottomTabsScreenSystemItemToUITabBarSystemItem(screenView.systemItem); | ||
| tabBarItem.image = [[UITabBarItem alloc] initWithTabBarSystemItem:systemItem tag:0].image; | ||
| } | ||
|
|
||
| if (screenView.selectedIconSfSymbolName != nil) { | ||
| tabBarItem.selectedImage = [UIImage systemImageNamed:screenView.selectedIconSfSymbolName]; | ||
| } else if (screenView.systemItem != RNSBottomTabsScreenSystemItemNone) { | ||
| // Restore default system item icon | ||
| UITabBarSystemItem systemItem = | ||
| rnscreens::conversion::RNSBottomTabsScreenSystemItemToUITabBarSystemItem(screenView.systemItem); | ||
| tabBarItem.selectedImage = [[UITabBarItem alloc] initWithTabBarSystemItem:systemItem tag:0].selectedImage; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limits changing tab bar item instances (PR introducing this) to only necessary cases (changing
systemItem). Unnecessary updates caused a bug when changing e.g. onlybadgeValue.before.mov
after.mov
Fixes #3273.
Changes
UITabBarIteminstance and updating tab bar item related propsUITabBarIteminstance only onsystemItemchangeUITabBarSystemIteminstance instead of changing the entireUITabBarItemTest code and steps to reproduce
Run
TestBottomTabs. ChangebadgeValueon selected tab. You can also check test cases from #3164.Checklist